SDK 1.4 issue os_zalloc

[scargill]

Hi

Up to now, various SDKs have been drop-in and recompile - this time with 1.4 I get an error when compiling this (which sadly I did not write so I don't want to mess it up).


void ICACHE_FLASH_ATTR QUEUE_Init(QUEUE *queue, int bufferSize)
{
queue->buf = (uint8_t*)os_zalloc(bufferSize);
RINGBUF_Init(&queue->rb, queue->buf, bufferSize);
}


mqtt/queue.c:42:2: error: too many arguments to function 'pvPortZalloc'
queue->buf = (uint8_t*)os_zalloc(bufferSize);
^

[kolban]

When using SDK supplied APIs try and find the corresponding C header file that contains the prototype definitions. For os_<memory> functions, this is the file called "mem.h" contained in <SDK>/include/mem.h. Looking at that file, we will find that the definitions for items such as "os_zalloc" have been defined as macros with additional parameters for memory leak debugging.

I'd suggest including mem.h and removing any previously manually defined definitions of os_<memory> functions that you may have coded.

Neil

[eriksl]

Yes indeed, it looks this function now finally has a proper prototype and the prototype guessed by the author apparently was wrong.

This is actually a good thing, because improperly prototyped function calls can cause crashed and other unpredictable behaviour.

[tve]

The prototype changed with the memory tracing in SDK 1.4