[SOLVED] Problem with os_strcat and char-array

[Stational]

Hello,

this is my attempt to create a HTTP Get request header:

Code: Select all

   char requestText[120];
   strcat(requestText, "GET /myPHP.php?action=insert&value=");
   strcat(requestText, adcValue);
   strcat(requestText, "/ HTTP/1.1\r\nUser-Agent: curl/7.37.0\r\nHost: ");
   strcat(requestText, NET_DOMAIN);
   strcat(requestText, "\r\nAccept: */*\r\n\r\n");


this is what i get if i use

Code: Select all

os_printf(requestText);


Ô
@T«GET /myPHP.php?action=insert&value=155/ HTTP/1.1
User-Agent: curl/7.37.0
Host: http://www.myHost.org
Accept: */*

I don't know where these strange chars in front of the 'GET' come from? How do i get rid of them?

[tobewinner]

Hello,

this is my attempt to create a HTTP Get request header:

Code: Select all

   char requestText[120];
   strcat(requestText, "GET /myPHP.php?action=insert&value=");
   strcat(requestText, adcValue);
   strcat(requestText, "/ HTTP/1.1\r\nUser-Agent: curl/7.37.0\r\nHost: ");
   strcat(requestText, NET_DOMAIN);
   strcat(requestText, "\r\nAccept: */*\r\n\r\n");


this is what i get if i use

Code: Select all

os_printf(requestText);


Ô
@T«GET /myPHP.php?action=insert&value=155/ HTTP/1.1
User-Agent: curl/7.37.0
Host: http://www.myHost.org
Accept: */*

I don't know where these strange chars in front of the 'GET' come from? How do i get rid of them?

You should add

Code: Select all

memset(requestText, 0, 120);

before strcat
or you can change

Code: Select all

char requestText[120];

to

Code: Select all

char requestText[120] = {0};

[Stational]

Thanks a lot for your answer,

I found out, that this works also very well:

Code: Select all

os_sprintf(requestText, "GET /mySQLFunction.php?action=insert&value=%d / HTTP/1.1\r\nUser-Agent: curl/7.37.0\r\nHost: %s\r\nAccept: */*\r\n\r\n",adcRead,NET_DOMAIN);


[pratik]

Hello Stational,

Please explicitly initialize all variables and dynamically allocated memory for reliable code behavior. You still have to follow all the basic rules related to variables in C to avoid compiler specific problems.